[PATCH] D84997: [AutoFDO] Avoid merging inlinee samples multiple times

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

The multiple inline instance copies generated from loop unrolling or jump threading should have their own FunctionSamples objects. Why merging multiple inline instance to the outline profile will trigger assertion? Could you have a testcase for it?

For the second problem, we got a bug report for the same problem. I create a testcase and a fix in https://reviews.llvm.org/D84994. I think your fix is more concise while mine is a straightforward fix. If you think your fix is better, free to use the testcase in D84994 <https://reviews.llvm.org/D84994>. Otherwise, I can commit that one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84997/new/

https://reviews.llvm.org/D84997