[PATCH] D84994: [SampleFDO] Fix a crash when the sample profile uses md5 and -sample-profile-merge-inlinee is enabled

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 19:43:27 PDT 2020


davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:238
+/// callsite FunctionSamples recursively.
+void SetGUIDToFuncNameMapImpl(std::queue<FunctionSamples *> &FSToUpdate,
+                              DenseMap<uint64_t, StringRef> *Map) {
----------------
nit: name it UpdateFunctionSamples


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84994/new/

https://reviews.llvm.org/D84994



More information about the llvm-commits mailing list