[PATCH] D84927: [TargetPassConfig] Run MachineVerifier after more passes

Thu Jul 30 18:26:17 PDT 2020

ZhangKang marked 2 inline comments as done.
ZhangKang added a comment.

In D84927#2185618 <https://reviews.llvm.org/D84927#2185618>, @MaskRay wrote:

> If your build is configured with `-DLLVM_ENABLE_EXPENSIVE_CHECKS=on`, verifyer passes may be added even without `-verify-machineinstrs`. I assume you have tested them...

Yes, I have used `-DLLVM_ENABLE_EXPENSIVE_CHECKS=on` to test this patch. Now there are 42 lit errors and 78 lnt errors, and this patch doesn't cause new errors.

================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1176
 void TargetPassConfig::addOptimizedRegAlloc() {
-  addPass(&DetectDeadLanesID, false);
+  addPass(&DetectDeadLanesID);

----------------
arsenm wrote:
> I thought there were deeper problems here that prevented this, but it's great if that's not the case anymore
All the test can be passes when enable verification for this pass.

================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1201

   addPass(&TwoAddressInstructionPassID, false);
   addPass(&RegisterCoalescerID);
----------------
arsenm wrote:
> I assume there's still a problem for TwoAddressInstructionPass?
Yes, there still are errors for `TwoAddressInstructionPass?`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84927/new/

https://reviews.llvm.org/D84927