[PATCH] D84922: [X86][AVX512] Fix build fail after D81548

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 18:23:26 PDT 2020


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:38442
       if (SDValue V =
               combineBitcastToBoolVector(VT, N0, SDLoc(N), DAG, Subtarget))
         return V;
----------------
yubing wrote:
> RKSimon wrote:
> > We might be able to recover from some of the regressions if we can use this before legalization as well?
> Eh, You mean we do the combineBitcastToBoolVector before legalizaeType procedure regardless of whether VT is Legal and let LegalizeType procedure handle the illegal Type?
I made a mistake. v16i1 is legal for avx512f. There's no regressions now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84922/new/

https://reviews.llvm.org/D84922



More information about the llvm-commits mailing list