[PATCH] D84944: [JumpThreading] Let SimplifyPartiallyRedundantLoad look into freeze

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 17:11:00 PDT 2020


aqjune added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:1181
+    // Look into freeze's operand
+    SimplifyValue = FI->getOperand(0);
+
----------------
efriedma wrote:
> Am I understanding correctly, that SimplifyPartiallyRedundantLoad is actually a legal transform for arbitrary load instructions, but we have a heuristic so we only perform it for "important" instructions?
Yes, that is correct. Since freeze is still there, it does not make the code more undefined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84944/new/

https://reviews.llvm.org/D84944



More information about the llvm-commits mailing list