[PATCH] D84419: Fix interaction between stack alignment and inline-asm stack clash protection

Josh Stone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 16:33:57 PDT 2020


cuviper added a comment.

Can you add tests that show what this is intended to look like for alignments greater than the probe step size?

Right now AFAICS you're just adding the alignment, which doesn't make sense to me. In the Rust code I examined, alignment was achieved by ANDing an alignment mask, which essentially rounds down to the next aligned address. That's a dynamically-sized address range that needs to be part of the probing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84419/new/

https://reviews.llvm.org/D84419



More information about the llvm-commits mailing list