[PATCH] D84949: [JumpThreading] Don't limit the type of an operand
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 30 12:40:41 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:685
// Handle Cast instructions. Only see through Cast when the source operand is
// PHI, Cmp, or Freeze to save the compilation time.
if (CastInst *CI = dyn_cast<CastInst>(I)) {
----------------
Oh, hmm, I misintepreted this comment, and didn't read the code carefully enough. The "if" is actually a heuristic that suppresses potential optimizations.
Do you have any idea what the actual compile-time impact would be if we just recursed over all casts?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84949/new/
https://reviews.llvm.org/D84949
More information about the llvm-commits
mailing list