[PATCH] D84959: [NewPM][LVI] Abandon LVI after CVP

Thu Jul 30 12:31:43 PDT 2020

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

In D84959#2185560 <https://reviews.llvm.org/D84959#2185560>, @nikic wrote:

> Here is how updating one of the tests would look like: https://gist.github.com/nikic/577dead281f1aee10b492c3fc7130f5b
>
> This would look nice if it only printed when an analysis actually gets invalidated, but I feel that the large number of "Invalidating all non-preserved analyses for" messages make this test worse.

Agree that is ugly. I'm ok with using the option then. The patch LGTM (but looks like it needs a clang format). Please wait to see if @aeubanks  has any more comments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84959/new/

https://reviews.llvm.org/D84959