[PATCH] D84940: [JumpThreading] Conditionally freeze its condition when unfolding select

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a reviewer: eugenis.
efriedma added a comment.

I'm not sure about your plan for enabling this.  You're going to get very little practical test coverage enabling this for "LTO".  (Big projects are much more likely to be using ThinLTO.)  And long-term, we don't to have a "please miscompile my code" argument for the JumpThreading pass.



================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2809
+  if (!InsertFreezeWhenUnfoldingSelect &&
+      BB->getParent()->hasFnAttribute(Attribute::SanitizeMemory))
     return false;
----------------
I suspect we don't want to change this.  Even if "freeze" version of the transform is legal with msan, it probably reduces the quality of msan diagnostics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84940/new/

https://reviews.llvm.org/D84940