[lld] ed7bde0 - [ELF][test] Fix ppc64-reloc-pcrel34-overflow.s

[Fāng-ruì Sòng via llvm-commits]

Noted. I should have included more description in my comment to
https://reviews.llvm.org/D84885

On Thu, Jul 30, 2020 at 10:28 AM Robinson, Paul <paul.robinson at sony.com> wrote:
>
> Hi @Fangrui Song
>
> "Fix a test" isn't particularly descriptive, especially in cases
> like this one where the problem isn't obvious.  Please include
> more detail in the future.
>
> Thanks,
> --paulr
>
> > -----Original Message-----
> > From: llvm-commits <llvm-commits-bounces at lists.llvm.org> On Behalf Of
> > Fangrui Song via llvm-commits
> > Sent: Wednesday, July 29, 2020 4:02 PM
> > To: llvm-commits at lists.llvm.org
> > Subject: [lld] ed7bde0 - [ELF][test] Fix ppc64-reloc-pcrel34-overflow.s
> >
> >
> > Author: Fangrui Song
> > Date: 2020-07-29T13:01:31-07:00
> > New Revision: ed7bde0e4b40cbf8a7c833fd8240c957fcda176e
> >
> > URL: https://github.com/llvm/llvm-
> > project/commit/ed7bde0e4b40cbf8a7c833fd8240c957fcda176e
> > DIFF: https://github.com/llvm/llvm-
> > project/commit/ed7bde0e4b40cbf8a7c833fd8240c957fcda176e.diff
> >
> > LOG: [ELF][test] Fix ppc64-reloc-pcrel34-overflow.s
> >
> > Added:
> >
> >
> > Modified:
> >     lld/test/ELF/ppc64-reloc-pcrel34-overflow.s
> >
> > Removed:
> >
> >
> >
> > ##########################################################################
> > ######
> > diff  --git a/lld/test/ELF/ppc64-reloc-pcrel34-overflow.s
> > b/lld/test/ELF/ppc64-reloc-pcrel34-overflow.s
> > index a97160a430dd..ad80ed720b63 100644
> > --- a/lld/test/ELF/ppc64-reloc-pcrel34-overflow.s
> > +++ b/lld/test/ELF/ppc64-reloc-pcrel34-overflow.s
> > @@ -1,21 +1,22 @@
> >  # REQUIRES: ppc
> >  # RUN: echo 'SECTIONS { \
> > -# RUN:       .text_low 0x10010000: { *(.text_low) } \
> > -# RUN:       .text_overflow 0x1000000000 : { *(.text_overflow) } \
> > -# RUN:       }' > %t.script
> > +# RUN:   .text 0x10000: { *(.text) } \
> > +# RUN:   .data 0x200010000 : { *(.data) } \
> > +# RUN: }' > %t.script
> >
> >  # RUN: llvm-mc -filetype=obj -triple=powerpc64le %s -o %t.o
> > -# RUN: not ld.lld -T %t.script %t.o -o %t
> > +# RUN: not ld.lld -T %t.script %t.o -o /dev/null 2>&1 | FileCheck %s
> >
> >  # RUN: llvm-mc -filetype=obj -triple=powerpc64 %s -o %t.o
> > -# RUN: not ld.lld -T %t.script %t.o -o %t
> > +# RUN: not ld.lld -T %t.script %t.o -o /dev/null 2>&1 | FileCheck %s
> >
> > -.section .text_low, "ax", %progbits
> > -# CHECK: relocation R_PPC64_PCREL34 out of range
> > -GlobIntOverflow:
> > +# CHECK: relocation R_PPC64_PCREL34 out of range: 8589934592 is not in [-
> > 8589934592, 8589934591]
> >       plwa 3, glob_overflow at PCREL(0), 1
> > -     blr
> > -.section .text_overflow, "ax", %progbits
> > +
> > +# CHECK-NOT: relocation
> > +     plwa 3, .data at PCREL(0), 1
> > +
> > +.data
> >  glob_overflow:
> >       .long   0
> >       .size   glob_overflow, 4
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



-- 
宋方睿