[PATCH] D84399: [SCEVExpander] Avoid re-using existing casts if it means updating users.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 11:18:50 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/pr27056.ll:39
 ; CHECK:       for.body:
 ; CHECK-NEXT:    [[TMP5:%.*]] = inttoptr i64 [[LSR_IV]] to %struct.L*
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq %struct.L* [[UGLYGEP1]], [[TMP]]
----------------
lebedev.ri wrote:
> Why were we emitting an unused instruction in the first place?
That's probably due to the cast re-using logic, which in some cases makes certain values dead by replacing all uses with an equivalent cast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84399/new/

https://reviews.llvm.org/D84399



More information about the llvm-commits mailing list