[PATCH] D84905: [MemorySSA] Restrict optimizations after a PhiTranslation.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:525
   DenseSet<ConstMemoryAccessPair> VisitedPhis;
+  bool PerformedPhiTranslation = false;
 
----------------
might be worth adding a comment, describing what it means (and when it will be reset).

Also, would it make sense to move this to a datastructure already tied to a set of paths that are explored together, e.g. the `UpwardsMemoryQuery`? The current approach seems fine to me, I am just wondering if we could reduce the scope of the variable a bit (and avoid relying on the reset calls).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84905/new/

https://reviews.llvm.org/D84905