[PATCH] D84874: [SVE][CodeGen] Legalisation of INSERT_VECTOR_ELT for scalable vectors

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7200
+
+    return DAG.getNode(ISD::UMIN, dl, IdxVT, Idx, Sub);
+  } else {
----------------
efriedma wrote:
> The non-scalable path uses masking; I guess you can't do that here because the element count might not be a power of two?  Given that, the end result here isn't great, but I can't come up with anything better.
Yes, masking wasn't used here since we can't be sure that `NElts` is a power of two


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84874/new/

https://reviews.llvm.org/D84874