[PATCH] D84462: Rename options for basic block sections to be consistent

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram marked an inline comment as done.
tmsriram added a comment.

In D84462#2183765 <https://reviews.llvm.org/D84462#2183765>, @MaskRay wrote:

> `lld/test/ELF/lto/basic-block-sections.ll` should be placed in another patch. Adding a new test is unrelated to renaming the whole bunch of test files.

Okay, I will separate the test out.



================
Comment at: lld/test/ELF/lto/basic-block-sections.ll:5
+; RUN: llvm-readobj -s %t.lto.o | FileCheck --check-prefix=SECNAMES %s
+; RUN: ld.lld %t.o -o %t --lto-basic-block-sections=all --lto-unique-basic-block-section-names --lto-O0 --save-temps
+; RUN: llvm-readobj -s %t.lto.o | FileCheck --check-prefix=SECNAMES-FULL %s
----------------
MaskRay wrote:
> `--lto-O2` is the default. I wonder if `--lto-O0` is significant. If not, please remove it.
Yes, it is intentional so that the basic blocks are not optimized away.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84462/new/

https://reviews.llvm.org/D84462