[PATCH] D84904: [flang] Fixes for RESHAPE()

[Tim Keith via Phabricator via llvm-commits]

tskeith added inline comments.


================
Comment at: flang/lib/Evaluate/fold-implementation.h:620
+    context_.messages().Say("Size of shape= argument must not be greater "
+                            "than %d"_err_en_US,
+        common::maxRank);
----------------
This message doesn't need to be split to fit into 80 columns.


================
Comment at: flang/lib/Evaluate/fold-implementation.h:624
+    context_.messages().Say("shape= argument must not have a negative "
+                            "extent"_err_en_US);
   } else {
----------------
Same here.


================
Comment at: flang/test/Semantics/reshape.f90:27
+  real :: array11(2,3) = RESHAPE([(n, n=1,4)], [2,3], [99], [2.2,3.3])
+  !ERROR: Invalid order= argument in RESHAPE
+  real :: array12(2,3) = RESHAPE([(n, n=1,4)], [2,3], [99], [1])
----------------
To be consistent with the messages above, `order=` should be in quotes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84904/new/

https://reviews.llvm.org/D84904