[PATCH] D84308: [PowerPC] Retrieve the offset from load/store if it stores to stack slots

Thu Jul 30 06:55:38 PDT 2020

jsji added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval.ll:759
 ; 32BIT-NEXT:   liveins: $r3, $r4, $r5, $r6, $r7, $r8, $r9, $r10
+; 32BIT-DAG:    STW killed renamable $r8,  20, %fixed-stack.0 :: (store 4 into %fixed-stack.0 + 20
 ; 32BIT-DAG:    STW killed renamable $r3,   0, %fixed-stack.0 :: (store 4 into %fixed-stack.0
----------------
steven.zhang wrote:
> jsji wrote:
> > Nit: this shouldn't be DAG -- STW 20 should be before others because of following overlapped LBZ.
> The DAG here means all the STW 20/0/4/8/12/16 are position independent. And then, we have a 32BIT as barrier, and then, another two position independent check which looks right from me.
Understand that they are independent, but if STW 20 is scheduled at the end, this should be a issue that we should be altered and looked into. Having DAG here will hide all such issues.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84308/new/

https://reviews.llvm.org/D84308