[PATCH] D84833: Implement indirect branch generation in position independent code for the RISC-V target

Thu Jul 30 05:40:50 PDT 2020

jrtc27 added a comment.

In D84833#2184491 <https://reviews.llvm.org/D84833#2184491>, @asb wrote:

> @jrtc27 are you happy with this patch now? Thanks for your review on this and thanks @msizanoen1 for providing this fix.
>
> I think @jrtc27's suggestion about deleting/moving the TODO line in test code still needs to be addressed.

Other than the TODO, yes (and hopefully you agree with my suggestions here!). I would also like to see branch-relaxation.ll grow RV64 RUN lines for completeness, even if it's probably a bit redundant (and creates a slight explosion..), but I can do that as a follow-up patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84833/new/

https://reviews.llvm.org/D84833