[PATCH] D84113: [Debuginfo] (1/N) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Hi @alok, would you be able to re-title the reviews in this stack to indicate  what's in the patch itself? That'll make it easier to navigate.



================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.h:125
+  DW_OP_LLVM_entry_value = 0x1003,      ///< Only used in LLVM metadata.
+  DW_OP_LLVM_implicit_pointer = 0x100c, ///< Only used in LLVM metadata.
 };
----------------
Any particular reason for 0x100c instead of the sequentially next 0x1004?


================
Comment at: llvm/test/DebugInfo/X86/LLVM_implicit_pointer.ll:2
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s
+
+; CHECK: !DIExpression(DW_OP_LLVM_implicit_pointer, 0)
----------------
Would you be able to add a file-comment along the lines of "round-trip test for implicit pointer metadata"? That'll make it easier for future readers to know what's being tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84113/new/

https://reviews.llvm.org/D84113