[PATCH] D84826: [NewPM][PassInstrumentation] Add AfterPassSkipped callback

Thu Jul 30 05:02:08 PDT 2020

yrouban abandoned this revision.
yrouban added a comment.

See D84772 <https://reviews.llvm.org/D84772>.

================
Comment at: llvm/include/llvm/IR/PassInstrumentation.h:81
   using BeforePassFunc = bool(StringRef, Any);
+  using AfterPassSkippedFunc = void(StringRef, Any);
   using AfterPassFunc = void(StringRef, Any, const PreservedAnalyses &);
----------------
ychen wrote:
> I would prefer BeforeSkippedPassFunc. To be compatible with D84772
With D84772 landed, this patch is not needed for D81558.
If BeforeNonSkippedPassFuncs is called, then there will be one of After* called.
So, I would vote for D84772 only.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84826/new/

https://reviews.llvm.org/D84826