[PATCH] D84651: [llvm-readobj] - Don't call `unwrapOrErr` in `findSectionByName`.

Thu Jul 30 02:59:37 PDT 2020

grimar added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-reginfo.test:23
+# NAME-ERR-FOUND-NEXT: warning: '[[FILE]]': unable to read the name of SHT_PROGBITS section with index 3: a section [index 3] has an invalid sh_name (0xffff) offset which goes past the end of the section name string table
+# NAME-ERR-FOUND:      The .reginfo section has a wrong size.
+
----------------
jhenderson wrote:
> Somewhat tangential, and definitely not part of this patch but "has a wrong size" sounds wrong to me (although I can't explain why). If you get a moment, changing it to "has an incorrect size" would be nice.
I have a plan to cleanup `ELFDumper<ELFT>::printMipsReginfo()` + refine the corresponding test file similar to as what D84854 did for `printMipsOptions()`. I'll change the message there.

D84854 , btw, prints:
```
warning: '[[FILE]]': the .MIPS.options section has a wrong size (0x1)
```

I guess I'll change it to "the .MIPS.options section has an incorrect size (0x1)" then too.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84651/new/

https://reviews.llvm.org/D84651