[PATCH] D84651: [llvm-readobj] - Don't call `unwrapOrErr` in `findSectionByName`.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-options-sec.test:43
+
+## Check we report a warning when we are unable to find the .MIPS.abiflags section due to an error.
+# RUN: yaml2obj --docnum=1 -DOPTNAME=0xffff %s -o %t.err2
----------------
`.MIPS.options`?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-reginfo.test:23
+# NAME-ERR-FOUND-NEXT: warning: '[[FILE]]': unable to read the name of SHT_PROGBITS section with index 3: a section [index 3] has an invalid sh_name (0xffff) offset which goes past the end of the section name string table
+# NAME-ERR-FOUND:      The .reginfo section has a wrong size.
+
----------------
Somewhat tangential, and definitely not part of this patch but "has a wrong size" sounds wrong to me (although I can't explain why). If you get a moment, changing it to "has an incorrect size" would be nice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84651/new/

https://reviews.llvm.org/D84651