[PATCH] D84921: [DWARFYAML] Make the debug_aranges entry optional.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 30 02:23:27 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:67
   DWARFDebugArangeSet Set;
-
+  std::vector<DWARFYAML::ARange> DebugAranges;
   while (ArangesData.isValidOffset(Offset)) {
----------------
It seems to me like you don't need this vector? Could you do `Y.DebugAranges.emplace()` to instantiate the vector in this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84921/new/

https://reviews.llvm.org/D84921



More information about the llvm-commits mailing list