[PATCH] D84817: Add verification for DW_AT_decl_file and DW_AT_call_file.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:556
+        }
+      } else {
+        ReportError("DIE has " + AttributeString(Attr) +
----------------
jhenderson wrote:
> Higuoxing wrote:
> > I think the brackets for `else` can be removed.
> My reading of recent updates to https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements is that if the `if` or `else` requires braces, the other half should too, so I think we actually want them here.
Seems that I missed it. Sorry for the misdirection.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84817/new/

https://reviews.llvm.org/D84817