[PATCH] D81429: [COFF] Port CallGraphSort to COFF from ELF

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 29 22:51:26 PDT 2020


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: lld/test/COFF/cgprofile-icf.s:2
+# REQUIRES: x86
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-win32 %s -o %t
----------------
zequanwu wrote:
> hans wrote:
> > Could you add a comment here that explains the intention of the test?
> This is ported from ELF/cgprofile-icf.s. I suppose the intention is to test the compatibility of ICF and cgprofile
Nit: Comments usually end with a full stop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81429/new/

https://reviews.llvm.org/D81429



More information about the llvm-commits mailing list