[PATCH] D84911: [DWARFYAML] Make the 'Length' field of the address range table optional.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 29 22:42:15 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:145
+
+ uint64_t PaddedHeaderLength = alignTo(HeaderLength, AddrSize * 2);
+ Length += PaddedHeaderLength - HeaderLength;
----------------
`const uint64_t PaddedHeaderLength`
================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:149
+
+ if (Range.Length)
+ Length = *Range.Length;
----------------
You can move Length assignment above to the else branch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84911/new/
https://reviews.llvm.org/D84911
More information about the llvm-commits
mailing list