[PATCH] D84900: [X86] Parse and ignore .arch directives

Wed Jul 29 21:38:43 PDT 2020

MaskRay marked an inline comment as done.
MaskRay added inline comments.

================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:4039
+  if (Kind == X86::CK_None)
+    return Error(Loc, "unknown arch name");
+  return false;
----------------
craig.topper wrote:
> I don't think the assembler's arch list matches the frontend -march list which is what parseArchX86 contains. Here's some docs for .arch https://sourceware.org/binutils/docs-2.31/as/i386_002dArch.html   X86::parseArchX86 does not support i8086, i186, i286 and many others. It also looks like .arch can take features like .sse
Thanks. Let's ignore the operand for now.

The newer documentation is at 
https://sourceware.org/binutils/docs/as/i386_002dArch.html#i386_002dArch

I find a few allowed values by looking at gas testsuite.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84900/new/

https://reviews.llvm.org/D84900