[PATCH] D84900: [X86] Parse and ignore .arch directives

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:4039
+  if (Kind == X86::CK_None)
+    return Error(Loc, "unknown arch name");
+  return false;
----------------
I don't think the assembler's arch list matches the frontend -march list which is what parseArchX86 contains. Here's some docs for .arch https://sourceware.org/binutils/docs-2.31/as/i386_002dArch.html   X86::parseArchX86 does not support i8086, i186, i286 and many others. It also looks like .arch can take features like .sse


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84900/new/

https://reviews.llvm.org/D84900