[PATCH] D84630: [StackSafety] Skip ambiguous lifetime analysis

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/Analysis/StackLifetime.cpp:301
+    case LivenessType::Must:
+      LiveRanges.resize(NumAllocas, LiveRange(Instructions.size()));
+      break;
----------------
t.p.northover wrote:
> Doesn't this case need the loop below? It looks like it's undoing all the extra default initialization caused by the resize.
> 
> Actually, I'd be inclined to reword the whole thing in terms of resizing with the default and separately setting `NumAllocas - 1` if that is the correct reading.
Loop below sets Full range for uninteresting allocas, however with HasUnknowLifetimeStartOrEnd we can't be sure which are uninteresting,
Other than that I am not sure what are you asking.


================
Comment at: llvm/test/Analysis/StackSafetyAnalysis/lifetime.ll:781
 
-ret void
+  ret void
+}
----------------
eugenis wrote:
> Is this a tab character?
no


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84630/new/

https://reviews.llvm.org/D84630