[PATCH] D84890: AMDGPU: Put inexpensive ops first in AMDGPUAnnotateUniformValues::visitLoadInst

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:137
+  if (PtrI)
+    NotClobbered= isEntryFunc && !isClobberedInFunction(&I);
+  else if (isa<Argument>(Ptr) || isa<GlobalValue>(Ptr)) {
----------------
Missing space


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:137
+  if (PtrI)
+    NotClobbered= isEntryFunc && !isClobberedInFunction(&I);
+  else if (isa<Argument>(Ptr) || isa<GlobalValue>(Ptr)) {
----------------
arsenm wrote:
> Missing space
Why does this need to check isEntryFunc in both places? The answer is always no if it's not an entry function


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84890/new/

https://reviews.llvm.org/D84890