[PATCH] D84685: [llvm][NFC] TensorSpec abstraction for ML evaluator

[Eugene via Phabricator via llvm-commits]

ebrevdo requested changes to this revision.
ebrevdo added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Analysis/TFUtils.cpp:136
+  bool checkReportAndInvalidate(const TF_Output &Output,
+                                const TensorSpec &Spec);
 };
----------------
OutputSpec


================
Comment at: llvm/lib/Analysis/TFUtils.cpp:160
+  for (size_t I = 0; I < InputSpecs.size(); ++I) {
+    auto &Spec = InputSpecs[I];
+    InputFeed[I] = {TF_GraphOperationByName(Graph.get(), (Spec.name()).c_str()),
----------------
InputSpec


================
Comment at: llvm/lib/Analysis/TFUtils.cpp:168
+  for (size_t I = 0; I < OutputSpecs.size(); ++I) {
+    auto &Spec = OutputSpecs[I];
     OutputFeed[I] = {
----------------
OutputSpec


================
Comment at: llvm/lib/Analysis/TFUtils.cpp:201
 bool TFModelEvaluatorImpl::checkReportAndInvalidate(const TF_Output &Output,
-                                                    StringRef Name) {
+                                                    const TensorSpec &Spec) {
   if (Output.oper)
----------------
OutputSpec


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84685/new/

https://reviews.llvm.org/D84685