[PATCH] D84872: [NewPM][opt] Revert to legacy PM when any codegen passes are specified

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/tools/opt/opt.cpp:493
+static bool IsCodegenPass(StringRef Pass) {
+  return Pass.startswith("x86-") || Pass.startswith("xcore-") ||
+         Pass.startswith("wasm-") || Pass.startswith("systemz-") ||
----------------
PassSets = {"a", "b"};
Passes = {"pa", "pb"};
for (P : PassSets)
   Pass.startswith
for (P : Passes)
   Pass == P


================
Comment at: llvm/tools/opt/opt.cpp:717
 
-  if (EnableNewPassManager || PassPipeline.getNumOccurrences() > 0) {
+  if ((EnableNewPassManager && !CodegenPassSpecifiedInPassList()) ||
+      PassPipeline.getNumOccurrences() > 0) {
----------------
Probably add comments about the effects of `-enable-new-pm`(on/off), `-run-pass`, `-passes`(opt/codegen pass), and the combination of them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84872/new/

https://reviews.llvm.org/D84872