[PATCH] D83986: GlobalISel: Define InvalidRegBankID enum value

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 29 09:04:24 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/utils/TableGen/RegisterBankEmitter.cpp:136
+
+  OS << "InvalidRegBankID = ~0u,\n";
+  unsigned ID = 0;
----------------
paquette wrote:
> Why 0 when it was -1 before?
This is still -1, just the unsigned interpretation. All of the code treats this as unsigned, so to avoid fixing up everywhere that uses these to use int, the enum needs to be switched to unsigned. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83986/new/

https://reviews.llvm.org/D83986



More information about the llvm-commits mailing list