[PATCH] D84817: Add verification for DW_AT_decl_file and DW_AT_call_file.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:82
 
+uint32_t DWARFDebugLine::Prologue::getLastValidFileIndex() const {
+  uint16_t DwarfVersion = getVersion();
----------------
I think `uint64_t` makes more sense here.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:556
+        }
+      } else {
+        ReportError("DIE has " + AttributeString(Attr) +
----------------
I think the brackets for `else` can be removed.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:562
+      }
+    } else {
+      ReportError("DIE has " + AttributeString(Attr) +
----------------
The brackets for `else` can be removed as well.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:566
+    }
+  } break;
   default:
----------------
This `break` should be put into the bracket?

```
- } break;
+   break;
+ }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84817/new/

https://reviews.llvm.org/D84817