[PATCH] D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef

[Kai Luo via Phabricator via llvm-commits]

lkail added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/mcp-dest-regs-no-dup.mir:1
+# RUN: llc -mtriple=arm-eabi -O1 -run-pass=machine-cp %s -o - 2>&1 | FileCheck %s
+--- |
----------------
Prefer adding `-verify-machineinstrs`, `-simplify-mir` and keep the line under 80 columns.


================
Comment at: llvm/test/CodeGen/ARM/mcp-dest-regs-no-dup.mir:1
+# RUN: llc -mtriple=arm-eabi -O1 -run-pass=machine-cp %s -o - 2>&1 | FileCheck %s
+--- |
----------------
lkail wrote:
> Prefer adding `-verify-machineinstrs`, `-simplify-mir` and keep the line under 80 columns.
Any reason to redirect stderr?


================
Comment at: llvm/test/CodeGen/ARM/mcp-dest-regs-no-dup.mir:13
+...
+---
+name:            h
----------------
LLVM IR from L2-L12 can be removed.


================
Comment at: llvm/test/CodeGen/ARM/mcp-dest-regs-no-dup.mir:16
+body:             |
+  bb.0 (%ir-block.0):
+
----------------
`(%ir-block.0)` can also be removed.


================
Comment at: llvm/test/CodeGen/ARM/mcp-dest-regs-no-dup.mir:20
+
+  ; CHECK: dead renamable [[REGISTER:lr|r[0-9]+]], renamable
+  ; CHECK-NOT: [[REGISTER]],
----------------
These `CHECK` directives are confusing to me. IIUC, `dead renamable $r9, renamable $r0 = UMULL renamable $lr, killed renamable $r0, 14 /* CC::al */, $noreg, $noreg` should keep what it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82638/new/

https://reviews.llvm.org/D82638