[PATCH] D84751: [Attributor][Not for commit] Make call site specific deduction default.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I looked at some and we need to check what is happening.



================
Comment at: llvm/test/Transforms/Attributor/ArgumentPromotion/control-flow.ll:36
 ; IS__TUNIT____-NEXT:  entry:
-; IS__TUNIT____-NEXT:    [[X:%.*]] = call i32 @callee(i1 [[C]], i32* nocapture nofree readonly [[P]])
-; IS__TUNIT____-NEXT:    ret i32 [[X]]
+; IS__TUNIT____-NEXT:    ret i32 undef
 ;
----------------
Something is off.


================
Comment at: llvm/test/Transforms/Attributor/IPConstantProp/solve-after-each-resolving-undefs-for-function.ll:65
 ; IS__TUNIT____-SAME: (i1 [[C:%.*]])
-; IS__TUNIT____-NEXT:    ret i32 99
+; IS__TUNIT____-NEXT:    unreachable
 ;
----------------
I don't see this.


================
Comment at: llvm/test/Transforms/Attributor/memory_locations.ll:614
+; IS__TUNIT____-NEXT:    [[R:%.*]] = call i8 @recursive_not_readnone_internal2(i8* undef, i1 [[C]])
+; IS__TUNIT____-NEXT:    ret i8 undef
+;
----------------
This should be 1, shouldn't it? 


================
Comment at: llvm/test/Transforms/Attributor/nocapture-2.ll:319
 ; CHECK:       cond.false:
-; CHECK-NEXT:    [[CALL2:%.*]] = call dereferenceable_or_null(4) i8* @scc_C(i16* noalias nofree nonnull readnone dereferenceable(4) "no-capture-maybe-returned" [[A]])
+; CHECK-NEXT:    [[CALL2:%.*]] = call nonnull dereferenceable(4294967295) i8* @scc_C(i16* noalias nofree nonnull readnone dereferenceable(4) "no-capture-maybe-returned" [[A]])
 ; CHECK-NEXT:    br label [[COND_END]]
----------------
kuter wrote:
> Is this normal ?
It can make sense, haven't verified it though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84751/new/

https://reviews.llvm.org/D84751