[PATCH] D84526: [yaml2obj] - Add a support for "<none>" value for all optional fields.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of nits. I'm also happy with other strings/syntax etc, as long as it's fairly readable.



================
Comment at: llvm/test/tools/yaml2obj/ELF/none-value.yaml:6
+## Test a few keys for which the "<none>" value is supported.
+## We do not test all of possible keys, because it would be too verbose.
+## It is a reasonable choice to test all keys for a section, because
----------------
all of -> all


================
Comment at: llvm/test/tools/yaml2obj/ELF/none-value.yaml:7
+## We do not test all of possible keys, because it would be too verbose.
+## It is a reasonable choice to test all keys for a section, because
+## normally many of them would conflict or intersect when specified together.
----------------
a resonable choice -> reasonable


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84526/new/

https://reviews.llvm.org/D84526