[PATCH] D84651: [llvm-readobj] - Don't call `unwrapOrErr` in `findSectionByName`.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 29 04:04:55 PDT 2020
grimar added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1275
+ if (!NameOrErr)
+ return createError("error locating the " + Name +
+ " section: " + toString(NameOrErr.takeError()));
----------------
jhenderson wrote:
> Maybe "unable to locate the" would be a better string here? That way, you don't have error repeated in the error message, and we won't have a situation in the future where the word "error" appears in a warning.
Done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84651/new/
https://reviews.llvm.org/D84651
More information about the llvm-commits
mailing list