[PATCH] D84722: [Attributor] Call site specific AAValueSimplification and AAIsDead.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Can you, maybe as a separate patch, run the update script with the call site deduction enabled *before* this patch and *after* to get the difference on all tests we have?



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:532
+  return AA->getCallBaseContext();
+}
+
----------------
is this supposed to be `static`? Please put it with the other "helpers" and add documentation.


================
Comment at: llvm/test/Transforms/Attributor/cb_liveness.ll:185
+; IS__TUNIT_____ENABLED-NEXT:    [[TMP4:%.*]] = zext i1 [[TMP3]] to i32
+; IS__TUNIT_____ENABLED-NEXT:    ret i32 [[TMP4]]
+;
----------------
Why are there no check lines for TUNIT w/o ENABLED, and CGSCC w/ ENABLED?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84722/new/

https://reviews.llvm.org/D84722