[PATCH] D84609: [MemDepAnalysis] Cut-off threshold reshuffling

[Evgeniy via Phabricator via llvm-commits]

ebrevnov added inline comments.


================
Comment at: llvm/include/llvm/Analysis/MemoryDependenceAnalysis.h:457
+                                        unsigned *LocalLimit = nullptr,
+                                        unsigned *GlobalLimit = nullptr);
 
----------------
lebedev.ri wrote:
> ebrevnov wrote:
> > I think we better avoid adding one more limit here since it complicates the API . It is enough to provide one limit to achieve the desired behavior. In particular a caller should specify a minimum of local and global limits.
> So you're suggesting that the caller should also take care of updating the global limit by how much the local limit got consumed?
That's right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84609/new/

https://reviews.llvm.org/D84609