[PATCH] D84234: [DWARFYAML] Implement the .debug_loclists section.

Tue Jul 28 21:26:49 PDT 2020

Higuoxing added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-loclists.yaml:757-758
+
+## t) Test that yaml2obj emits an error message if we use an unimplemented DWARF expression
+## operator.
+
----------------
jhenderson wrote:
> Rather than a known value that we one day will likely support, causing this test to be updated, perhaps we should pick a value that isn't supported by the DWARF spec?
I'm not sure if I'm doing right here. If we pick a value that isn't supported by the DWARF sepc, the error message

```
yaml2obj: error: DWARF expression: DW_OP_blah is not supported
                                   ^~~~~~~~~~
```

will be left untested.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84234/new/

https://reviews.llvm.org/D84234