[PATCH] D84793: [X86] Add assembler support for {disp8} and {disp32} to control the size of displacement used for memory operands.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 20:47:23 PDT 2020


echristo added a comment.

I think I'd find the conditionals easier to "read" if they were positive rather than negative? It'd help if the comments spelled out the conditions a little more as well.

Thoughts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84793/new/

https://reviews.llvm.org/D84793



More information about the llvm-commits mailing list