[PATCH] D84817: Add verification for DW_AT_decl_file and DW_AT_call_file.

[Greg Clayton via Phabricator via llvm-commits]

clayborg created this revision.
clayborg added reviewers: labath, aprantl, dblaikie.
Herald added subscribers: cmtice, arphaman, dexonsmith, hiraditya.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.
clayborg requested review of this revision.
Herald added a subscriber: MaskRay.

LTO builds have been creating invalid DWARF and one of the errors was a file index that was out of bounds. "llvm-dwarfdump --verify" will check all file indexes for line tables already, but there are no checks for the validity of file indexes in attributes.

The verification will verify if there is a DW_AT_decl_file/DW_AT_call_file that:

- there is a line table for the compile unit
- the file index is valid
- the encoding is appropriate

Tests are added that test all of the above conditions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84817

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/test/tools/llvm-dwarfdump/X86/verify_attr_file_indexes.yaml
  llvm/test/tools/llvm-dwarfdump/X86/verify_debug_info.s
  llvm/test/tools/llvm-dwarfdump/X86/verify_file_encoding.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84817.281447.patch
Type: text/x-patch
Size: 20558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200729/66a2631a/attachment.bin>