[PATCH] D83650: [FileCheck] Extend -dump-input with substitutions

Tue Jul 28 16:38:04 PDT 2020

jdenny added inline comments.

================
Comment at: llvm/test/FileCheck/dump-input-annotations.txt:635
+;
+; FIXME: Even CHECK-NOT should fail if a variable isn't defined, right?
+;--------------------------------------------------
----------------
thopre wrote:
> jdenny wrote:
> > thopre wrote:
> > > It should yes so you can rewrite the FIXME into something like "CHECK-NOT wrongly consider an undefined variable as a failure to match, fix first line input dump below once this is fixed".
> > > 
> > > IMHO, I think it should be fixed by making CheckNot handle UndefVarError errors and call a new printUndef and return true if any is found.
> > Let me know if the new text isn't what you had in mind.
> > 
> > There should probably be a bugzilla for this.  I'll try to look into it tomorrow.
> LGTM. I'd be happy to fix it but can only look at it in about a week from now. If you do create a bugzilla please add me in Cc so that I see if it has been fixed or whether I should get to it.
Bug is here:

https://bugs.llvm.org/show_bug.cgi?id=46880

I probably won't work on it anytime soon, so feel free to take it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83650/new/

https://reviews.llvm.org/D83650