[PATCH] D84153: AMDGPU: Relax restriction on folding immediates into physregs

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

In D84153#2180517 <https://reviews.llvm.org/D84153#2180517>, @rampitec wrote:

> It can probably create a worse code sometimes. Assume you have a constant which cannot be directly assigned to a register (v_accvgpr_write_b32 only accepts inline literals). If source def will not become dead it will create an extra copy. You probably need some legality checks here.

But that's really orthogonal to what you are doing and is a separate change. It equally related to virtual registers.

LGTM, just fix formatting at line 657.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84153/new/

https://reviews.llvm.org/D84153