[PATCH] D84782: [PGO] Include the mem ops into the function hash.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 16:13:41 PDT 2020


davidxl added a comment.

On version bump --- looks like FrontPGO has been bumping version for hashing changes while IR PGO had not, so it is ok to leave the version unchanged (current situation is also confusing as the version of IR and FE PGO are mixed).

On the other hand, just in case, we need to introduce a temporary internal option for people to be able to keep on using old profile (with older scheme of hashing) for a while. Basically, under the option, the hashing scheme falls back to the old way.

other than that, looks fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84782/new/

https://reviews.llvm.org/D84782



More information about the llvm-commits mailing list