[PATCH] D84168: AMDGPU: Account for the size of LDS globals used through constant expressions.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 15:46:38 PDT 2020


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:808
+  // value instead
+  std::sort(AllocatedSizes.begin(), AllocatedSizes.end(),
+            [](std::pair<uint64_t, Align> LHS, std::pair<uint64_t, Align> RHS) {
----------------
Could use llvm::sort instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84168/new/

https://reviews.llvm.org/D84168



More information about the llvm-commits mailing list