[PATCH] D84804: [SROA][Mem2Reg] Use efficient droppable use API (after D83976)

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 15:23:18 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:3090
       // TODO For now we forget assumed information, this can be improved.
-      OldPtr->dropDroppableUsesByUser(II);
+      OldPtr->dropDroppableUsesIn(II);
       return true;
----------------
efriedma wrote:
> We could pass down the Use here, if we cared; the caller computes it. But this is okay for now.
Yeah, that would have been a bit more intrusive (on first glance).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84804/new/

https://reviews.llvm.org/D84804



More information about the llvm-commits mailing list