[PATCH] D84654: GlobalISel: Implement lower for G_EXTRACT_VECTOR_ELT

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:5193
+LegalizerHelper::LegalizeResult
+LegalizerHelper::lowerExtractVectorElt(MachineInstr &MI) {
+  Register DstReg = MI.getOperand(0).getReg();
----------------
Would be nice to have a simple example of what the lowering looks like in the comment here; the testcase is pretty long.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:5199
+  LLT EltTy = VecTy.getElementType();
+  if (!EltTy.isByteSized()) // Not implemented.
+    return UnableToLegalize;
----------------
maybe some debug output here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84654/new/

https://reviews.llvm.org/D84654