[PATCH] D84609: [MemDepAnalysis] Cut-off threshold reshuffling
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 28 13:00:47 PDT 2020
lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.
================
Comment at: llvm/include/llvm/Analysis/MemoryDependenceAnalysis.h:457
+ unsigned *LocalLimit = nullptr,
+ unsigned *GlobalLimit = nullptr);
----------------
ebrevnov wrote:
> I think we better avoid adding one more limit here since it complicates the API . It is enough to provide one limit to achieve the desired behavior. In particular a caller should specify a minimum of local and global limits.
So you're suggesting that the caller should also take care of updating the global limit by how much the local limit got consumed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84609/new/
https://reviews.llvm.org/D84609
More information about the llvm-commits
mailing list