[PATCH] D84038: On Windows build, making the /bigobj flag global , instead of passing it per file.

Zahira Ammarguellat via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 12:45:40 PDT 2020


zahiraam added a comment.

In D84038#2179734 <https://reviews.llvm.org/D84038#2179734>, @mehdi_amini wrote:

> In D84038#2179551 <https://reviews.llvm.org/D84038#2179551>, @zahiraam wrote:
>
>> I actually made an attempt to commit the patch using arc but not sure it made it. This was my last command: git commit --amend -a
>> Do I need to push now? 
>> Thanks.
>
> You can use `arc land --revision D84038` or you can check what you're about to push: `git fetch origin && git log ^origin/master HEAD` ; if this is the commit you intend to push and the commit message is satisfying, then just push it.
>
> If you don't have push permissions, you need to ask here for someone to land it for you.

Can someone land it please? Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84038/new/

https://reviews.llvm.org/D84038



More information about the llvm-commits mailing list